Add lifetime-aware support for Display impl of Ident
#143185
Open
+112
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Urgau
reviewed
Jun 29, 2025
fmease
reviewed
Jun 29, 2025
fmease
added
S-waiting-on-author
xizheyin
force-pushed
the
143150
branch
2 times, most recently
from
c9addca to
c4edd71
Compare
xizheyin
commented
Jun 30, 2025
| } | ||
| return fmt::Display::fmt(&lifetime, f); | ||
| } | ||
|
|
||
| if self.is_raw { |
There was a problem hiding this comment.
When Ident starts with ', the contents are printed recursively.
Comment on lines
+2880
to
+2889
| if self.name == kw::StaticLifetime || self.name == kw::UnderscoreLifetime { | ||
| false | ||
| } else if let Some(lifetime) = self.as_lifetime() { | ||
| lifetime.is_raw_guess() | ||
| } else { | ||
| self.name.can_be_raw() && self.is_reserved() | ||
| } |
There was a problem hiding this comment.
There are two keywords that need to be excluded here.
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Signed-off-by: xizheyin <[email protected]>
xizheyin
changed the title
lifetime.identDisplay impl of Ident
xizheyin
force-pushed
the
143150
branch
2 times, most recently
from
d6c180d to
9306466
Compare
ada4a
reviewed
Jul 4, 2025
Signed-off-by: xizheyin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143150
r? compiler